Jump to content

Plasma/libplasma2/API Review/DataEngine

From KDE Community Wiki
Status Action Method
TO DO Remove explicit DataEngine(QObject *parent , KService::Ptr service); <{{{3}}}>
TO DO Add explicit DataEngine(QObject *parent, const KPluginInfo &info); <{{{3}}}>
TO DO Remove DataEngine(QObject *parent, const QVariantList &args); <{{{3}}}>
DONE Keep ~DataEngine();
TO DO Remove? virtual void init(); can be removed is there will be only one constructor <{{{3}}}>
DONE Keep virtual QStringList sources() const;
DONE Keep virtual Service *serviceForSource(const QString &source);
TO DO Add KPluginInfo pluginInfo() const; <{{{3}}}>
TO DO Remove QString name() const; <{{{3}}}>
TO DO Remove QString icon() const; <{{{3}}}>
TO DO Remove QString pluginName() const; <{{{3}}}>
DONE Keep void connectSource(const QString &source, QObject *visualization, uint pollingInterval, Plasma::IntervalAlignment intervalAlignment ) const;
DONE Keep void connectAllSources(QObject *visualization, uint pollingInterval, Plasma::IntervalAlignment intervalAlignment) const;
DONE Keep void disconnectSource(const QString &source, QObject *visualization) const;
DONE Keep DataContainer *containerForSource(const QString &source);
TO DO Remove DataEngine::Data query(const QString &source) const; <{{{3}}}>
DONE Keep bool isValid() const;
DONE Keep bool isEmpty() const;
DONE Keep  Package package() const;
TO DO Remove  Service* createDefaultService(QObject *parent ); <{{{3}}}>
TO DO Move  static QStringList listAllEngines(const QString &parentApp); -> in PluginLoader <{{{3}}}>
TO DO Move  static KPluginInfo::List listEngineInfo(const QString &parentApp); -> in PluginLoader <{{{3}}}>
TO DO Move static KPluginInfo::List listEngineInfoByCategory(const QString &category, const QString &parentApp); <{{{3}}}>
DONE Keep  void sourceAdded(const QString &source);
DONE Keep  void sourceRemoved(const QString &source);
DONE Keep virtual bool sourceRequestEvent(const QString &source);
DONE Keep virtual bool updateSourceEvent(const QString &source);
DONE Keep void setData(const QString &source, const QVariant &value);
DONE Keep void setData(const QString &source, const QString &key, const QVariant &value);
TO DO Signature void setData(const QString &source, const Data ->QHash<QString, QVariant> &data); -> Data becomes QHash<QString, QVariant> <{{{3}}}>
DONE Keep void removeAllData(const QString &source);
DONE Keep void removeData(const QString &source, const QString &key);
DONE Keep void addSource(DataContainer *source);
DONE Keep void setMinimumPollingInterval(int minimumMs);
DONE Keep int minimumPollingInterval() const;
DONE Keep void setPollingInterval(uint frequency);
DONE Keep void removeAllSources();
DONE Keep void setValid(bool valid);
TO DO Signature SourceDict -> QHash<QString, DataContainer*> containerDict() const; <{{{3}}}>
DONE Keep void timerEvent(QTimerEvent *event);
TO DO Remove void setName(const QString &name); <{{{3}}}>
TO DO Remove void setIcon(const QString &icon); <{{{3}}}>
TO DO Remove void setDefaultService(const QString &serviceName); <{{{3}}}>
DONE Keep void setStorageEnabled(const QString &source, bool store);
TO DO Move slot void scheduleSourcesUpdated(); -> to private class <{{{3}}}>
DONE Keep slot void removeSource(const QString &source);
DONE Keep slot  void updateAllSources();
DONE Keep slot  void forceImmediateUpdateOfAllVisualizations();