KMyMoney/PlayingWithAlkValue
This page contains some notes about the port of the mymoneymoney class to AlkValue (from alkimia).
Based on the forum, the general strategy is to derive MyMoneyMoney from AlkValue, such that
class MyMoneyMoney : public AlkValue {...};
In this way, most of the methods should be directly available, and others can be provided by MyMoneyMoney (such as the toDouble() method that is used by several classes).
This needs to be checked in order to avoid possible overflows.
Current status
- Removal of m_num and m_denom from MyMoneyMoney class. Using inheritance from AlkValue. Class compiling ok. Starting unit testing the new class.
- Dealing with String based constructor and its respective test.
- Problem: Apparently, AlkValue String constructor can not deal with "1,123.". It seems that the problem is caused by the "," in the converted string, which is not supported by the GMP mpq_class class.
Temporary fix: Copied the AlkValue string constructor to MyMoneyMoney class and eliminated the thousand separator.
Is it a fix for the AlkValue class?
- Problem: string constructor of AlkValue class normalize the fraction, while old constructor does not. This caused failures in the testStringConstructor.
Check where the normalization (reduce method) is used on the code. Decide whether normalize in the constructor like the AlkValue or to leave like the old constructor. For now follow the old constructor (Test passed without normalization in the constructor)
- Problem: Failed testNegativeStringConstructor. Fix for AlkValue class?
Fix: Changed the constructor code to consider negative symbols in separate. Either - or ().
- Dealing with convert method and its respective test
- Dealing with operators
- Issue: gmp requires normalized operands, while the operators of the current implementation of mymoneymoney does not normalize the values. This affect the unit tests. Check whether the normalization will be applied to all operators, or only when explicitly requested (reduce method).
- All tests passed apart from testFormatMoney.
- Possible problem in the multiplication against int.
MyMoneyMoney m1(100,1); m1 = m1 * 10;
m1 is printed as 10
- Need help with the formatMoney method.
MyMoneyMoney(100).formatMoney("", 2) is formatted as 100.00 MyMoneyMoney(1000).formatMoney("", 2) is formatted as 10.00 MyMoneyMoney(100099).formatMoney("", 2) is formatted as 1,000.99
Confirm if it is the expected behaviour.
- Dealing with the formatMoney method.
- Found the problem. Overflow when extracting int from mpz_class in the convert method.
testformatmoney requires a conversion with precision 10, while testconvert only considers precision 2.
- starting other tests of the mymoney module.
All passed
- Starting tests from the root directory.
All tests passed.
- Checking the software using some sample files.
- Crashing when opening the ledger view
Problem identified. Continuing with tests using sample files.
- Crash when entering new deposit.
- Problem identified. The string constructor is not working for 0.08 or 0.09, although it works for 0.07. Changed the unit test to show this.
Need help reviewing the code.
Classes that include the mymoneymoney.h file
These classes may be directed affected by the changes.
- converter/webpricequote.h
- converter/mymoneyqifprofile.cpp
- converter/mymoneygncreader.cpp
- dialogs/knewequityentrydlg.cpp
- dialogs/knewaccountdlg.h
- dialogs/ksplittransactiondlg.h
- mymoney/mymoneybudget.h
- mymoney/mymoneyforecast.h
- mymoney/mymoneymoney.cpp
- mymoney/mymoneysecurity.h
- mymoney/mymoneyscheduletest.cpp
- mymoney/mymoneysplit.h
- mymoney/mymoneytransaction.h
- mymoney/mymoneystatement.h
- mymoney/mymoneymoneytest.cpp
- mymoney/storage/mymoneystoragesql.h
- mymoney/mymoneyfinancialcalculatortest.cpp
- mymoney/mymoneyaccount.h
- mymoney/mymoneyprice.h
- plugins/printcheck/numbertowords.h
- reports/reportstestcommon.h
- views/kscheduletreeitem.cpp
- widgets/kpricetreeitem.cpp
- widgets/kmymoneyedit.cpp
- widgets/registeritem.h
- wizards/newinvestmentwizard/konlineupdatewizardpage.cpp
- wizards/newinvestmentwizard/kinvestmentdetailswizardpage.cpp
- wizards/newuserwizard/knewuserwizard.cpp
- wizards/newloanwizard/additionalfeeswizardpage.cpp