Jump to content

KDE PIM/KHolidays: Difference between revisions

From KDE Community Wiki
Jlayt (talk | contribs)
Dvratil (talk | contribs)
No edit summary
 
(8 intermediate revisions by 2 users not shown)
Line 5: Line 5:
The KHolidays library in kdepimlibs provides details on public holidays for a given country and date range.  A separate library and file format is required as iCalendar is not capable of expressing recurrence rules for all possible holidays.
The KHolidays library in kdepimlibs provides details on public holidays for a given country and date range.  A separate library and file format is required as iCalendar is not capable of expressing recurrence rules for all possible holidays.


== OpenHolidays GSOC Project ==
To request support for a new country, or to request fixes to existing files, please file a [https://bugs.kde.org/enter_bug.cgi?product=kdepimlibs&component=kholidays&format=guided feature request or bug report].
 
A [http://community.kde.org/GSoC/2014/Ideas#Project:_OpenHolidays GSOC 2014 project proposal] has been submitted in implement a replacement for KHolidays.  This new project will be known as OpenHolidays as a primary aim is to set up a cross-platform data resource.  This section documents the background reading required for candidates for this project.  If you wish to apply for the project, please [https://mail.kde.org/mailman/listinfo/kde-pim subscribe to the [email protected] mailing list] and send your initial contact email there with a cc to [email protected].
 
A good introduction to the project is the [https://www.desktopsummit.org/sites/www.desktopsummit.org/files/CalSysHolidaysDS2011.pdf presentation done at the Berlin Desktop Summit in August 2011]. (Note the Calendar System implementations details are out of scope for this project).
 
Next, read through the contents of this wiki page and follow the various links, in particular look through:
* The current KHoliday library API
* The current KHoliday data files (but don't worry too much about understanding the file format)
* The various proposals for new file formats in XML and JSON
* Pay particular attention to the new OpenHolidays design notes
 
 
One compulsory requirement is to integrate the new QOpenHolidays library into KDE using the Akonadi PIM server in a manner similar to iCalendar files where a base event has a start and end date with recurrence dates able to be queried (KHolidays does not offer such an api).
* Learn some of the basics for the [http://en.wikipedia.org/wiki/Icalendar iCalendar design], in particular the relationship between base events and recurrences
* Learn some of the basics of the [http://api.kde.org/4.x-api/kdepimlibs-apidocs/kcalcore/html/index.html KCalCore library], KDE PIM's implementation of an iCalendar library, that QOpenHolidays should operate in a similar manner to.
* Learn some of the [http://community.kde.org/KDE_PIM/Akonadi basics of Akonadi] and how KCalCore integrates into it as a resource, which QOpenHolidays should operate in a similar manner to.


 
If you wish to write a new file yourself, please follow the instructions for [https://cgit.kde.org/kholidays.git/tree/holidays/file-format.txt writing a new holiday file].
A major concern is the localization of the files, so you need some understanding of how the [http://techbase.kde.org/Localization KDE localization system works].
 
It is recommended to get some familiarity with the KDE code development process by submitting some small bug fixes. In this case you could look in Bugzilla for KHolidays data file updates that need to be done.


== Maintainers ==
== Maintainers ==
Line 36: Line 17:


* API: [http://api.kde.org/4.x-api/kdepimlibs-apidocs/kholidays/html/index.html Browse api.kde.org]
* API: [http://api.kde.org/4.x-api/kdepimlibs-apidocs/kholidays/html/index.html Browse api.kde.org]
* Code: [https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/master/show/kholidays Browse projects.kde.org]
* Code: [http://quickgit.kde.org/?p=kdepimlibs.git&a=tree&f=kholidays Browse quickgit.kde.org]
* Code: [http://quickgit.kde.org/?p=kdepimlibs.git&a=tree&f=kholidays Browse quickgit.kde.org]
* Bugs: [https://bugs.kde.org/buglist.cgi?query_format=advanced&product=kdepimlibs&component=kholidays&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=NEEDSINFO Bugzilla Search]
* Bugs: [https://bugs.kde.org/buglist.cgi?query_format=advanced&product=kdepimlibs&component=kholidays&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=NEEDSINFO Bugzilla Search]
Line 45: Line 25:
* Alternative calendar systems (Hebrew, Islamic, etc)
* Alternative calendar systems (Hebrew, Islamic, etc)
* Special date calculations, currently Easter and Orthodox Easter, but can include events like solstices, or any named day of the year.
* Special date calculations, currently Easter and Orthodox Easter, but can include events like solstices, or any named day of the year.
* Commemoration date, i.e. Christmas occurs on a Sunday, you get the Monday off.
* Observance date, i.e. Christmas occurs on a Sunday, you get the Monday off.
* Holiday Class, i.e.day-of,not day off, religious day off, school holiday, etc
* Holiday Class, i.e.day-of,not day off, religious day off, school holiday, etc
* Holiday Categories, i.e. Cutural, Official, Religious, etc.
* Holiday Categories, i.e. Cutural, Official, Religious, etc.
Line 53: Line 33:
The file format originally used was the PLAN format, but this has been extended a number of times to support new features.  The limits of the format have about been reached and it is too complex for easy maintenance.  It is intended to add a few more features to the format then to design a new XML file format to replace it.
The file format originally used was the PLAN format, but this has been extended a number of times to support new features.  The limits of the format have about been reached and it is too complex for easy maintenance.  It is intended to add a few more features to the format then to design a new XML file format to replace it.


* Historic document: http://community.kde.org/KDE_PIM/KOrganizer/Holiday_File_Format
* Current [[KDE_PIM/KHolidays/File_Format|file format]]
* Historic [[KDE_PIM/KOrganizer/Holiday_File_Format|document]]


== Related Projects ==
== Related Projects ==
Line 366: Line 347:
   Duration    duration () const
   Duration    duration () const
   bool    hasDuration () const
   bool    hasDuration () const
== OpenHolidays GSOC Project ==
A [http://community.kde.org/GSoC/2014/Ideas#Project:_OpenHolidays GSOC 2014 project proposal] has been submitted in implement a replacement for KHolidays.  This new project will be known as OpenHolidays as a primary aim is to set up a cross-platform data resource.  This section documents the background reading required for candidates for this project.  If you wish to apply for the project, please [https://mail.kde.org/mailman/listinfo/kde-pim subscribe to the [email protected] mailing list] and send your initial contact email there with a cc to [email protected].
A good introduction to the project is the [https://www.desktopsummit.org/sites/www.desktopsummit.org/files/CalSysHolidaysDS2011.pdf presentation done at the Berlin Desktop Summit in August 2011]. (Note the Calendar System implementations details are out of scope for this project).
Next, read through the contents of this wiki page and follow the various links, in particular look through:
* The current KHoliday library API
* The current KHoliday data files (but don't worry too much about understanding the file format)
* The various proposals for new file formats in XML and JSON
* Pay particular attention to the new OpenHolidays design notes
One compulsory requirement is to integrate the new QOpenHolidays library into KDE using the Akonadi PIM server in a manner similar to iCalendar files where a base event has a start and end date with recurrence dates able to be queried (KHolidays does not offer such an api).
* Learn some of the basics for the [http://en.wikipedia.org/wiki/Icalendar iCalendar design], in particular the relationship between base events and recurrences
* Learn some of the basics of the [http://api.kde.org/4.x-api/kdepimlibs-apidocs/kcalcore/html/index.html KCalCore library], KDE PIM's implementation of an iCalendar library, that QOpenHolidays should operate in a similar manner to.
* Learn some of the [http://community.kde.org/KDE_PIM/Akonadi basics of Akonadi] and how KCalCore integrates into it as a resource, which QOpenHolidays should operate in a similar manner to.
A major concern is the localization of the files, so you need some understanding of how the [http://techbase.kde.org/Localization KDE localization system works].
It is recommended to get some familiarity with the KDE code development process by submitting some small bug fixes.  In this case you could look in Bugzilla for KHolidays data file updates that need to be done.

Latest revision as of 15:42, 27 July 2017

The KHolidays Library

Introduction

The KHolidays library in kdepimlibs provides details on public holidays for a given country and date range. A separate library and file format is required as iCalendar is not capable of expressing recurrence rules for all possible holidays.

To request support for a new country, or to request fixes to existing files, please file a feature request or bug report.

If you wish to write a new file yourself, please follow the instructions for writing a new holiday file.

Maintainers

  • John Layt (IRC jlayt)
  • Allen Winter

Resources

Features

The following features are available in KHolidays that are not supported in iCalendar:

  • Alternative calendar systems (Hebrew, Islamic, etc)
  • Special date calculations, currently Easter and Orthodox Easter, but can include events like solstices, or any named day of the year.
  • Observance date, i.e. Christmas occurs on a Sunday, you get the Monday off.
  • Holiday Class, i.e.day-of,not day off, religious day off, school holiday, etc
  • Holiday Categories, i.e. Cutural, Official, Religious, etc.

File Format

The file format originally used was the PLAN format, but this has been extended a number of times to support new features. The limits of the format have about been reached and it is too complex for easy maintenance. It is intended to add a few more features to the format then to design a new XML file format to replace it.

Related Projects

Future Plans


The following development plan is designed to become a Freedesktop.org project so that the maintenance burden can be shared with Gnome and any other interested parties.

  • Design a new XML based file format
  • Convert KDE files to new format
  • Implement a base C (?) library to parse the XML file and calculate the holidays, will include calendar systems if not in glibc by then. No desktop specific code allowed, i.e. to be equivalent to libical.
  • Implement a pure Qt library to wrap the C library in kdesupport
  • Implement an Akonadi resource


A proposal was presented at the Berlin Desktop Summit in August 2011. The slides from the talk go into more detail.

Rough Notes From KHolidays TODO

KHolidays

  • KHolidays: Holiday types, day-off types.
  • Split the existing holiday files up into civil and religious files and create a better naming scheme including country, language, region and type.
  • Finalise the required file metadata fields (name, region, language, etc).
  • Add holiday class/category syntax (e.g. Public / Religious / Cultural / Financial Holiday etc). Holidays can have multiple classes/categories, implement as flags.
  • Improve the SHIFT syntax to cater for more complex rules (e.g. the Boxing Day problem). Add optional name for day shifted to.
  • Add a NOOP or EXCLUDE syntax to allow holidays to only occur in some years and not others.
  • Solstice/Equinox keywords and functions (like Easter).
  • If holiday has a duration > 1 day return only one Holiday instance with a duration and/or end date attribute set, rather than multiple Holiday instances. This will allow the client app to choose whether to display as a singled spanned entry or multiple entries, and may make de-duping easier.
  • Return attributes of both original date of holiday and shifted to observation date, and if original date is still a holiday or not. Option to have different names shown for each date.
  • Try sort out translation of the file names, the desktop file might be the way to go.
  • Hebrew special event calculations
  • So would that mean HolidayRegion::locations() (or the equivalent) could be passed an argument that means it will only return those locations that have holiday files of a particular type (e.g. civil)?
  • Any plans to add a way of selecting holiday calendars to the KDE Control Module (Country/Region & Language)?
  • I think we would have to have 2 sets, a top-level or global faith/language set, then a region/faith/language set for local variations (where faith means a religion or any sub-set within that religion). For the top-level the filename itself would just use a region code of xx which is the ISO code for supra-national groups. So something like holiday_xx_es_catholic with a metadata display name of "Catholic (Spanish)" and holiday_ar_es_catholic with "Argentine Catholic (Spanish)".
  • The design actually has a nice directory based hierarchy for this, I'll have a think if we want to do that yet.
  • allow them to choose to display multiple holiday files at the same time to know which is their 'official' holiday file for days-off to show in red, and if they select a second civil region to display those days-off won't be marked in red but in blue for information only. But that might be a per-file setting, someone might want both sets of days off!
  • Some control over what colours are used will be needed too.


<holiday predefined="christmas" region="GB" type="public,religious">
  <observance move-type="both-days" days-off="both-days" language="en_GB">Christmas Day Bank Holiday</observance>
</holiday>

<holiday region=NZ_WN type="public">
  <name language="en_NZ">Wellington Anniversary Day</name>
  <observance calendar="gregorian" month="01" day="22" started="1853" />
</holiday>


Old design:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE holidayCalendar >

<!-- US Federal Holidays -->


<!-- Federal Holidays in The United States -->
<holidayCalendar name="Federal" type="political">

  
<-- New Year's Day -->
  <holiday type="public" workDayOff="true" schoolDayOff="true">
    <name>New Year's Day</name>
    <datespec>
      <posdate position="fourth" dayOfWeek="thursday" month="11">
        <plus days="1"/>
      </posdate>
    </datespec>
    <description>Start of year, marks traditional end of holiday season</description>
  </holiday>

</holidayCalendar>

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE features >

<!-- Maryland State Holidays

     Includes all the federal holidays plus
       Election Day (even years only)
       Day After Thanksgiving
-->

<!-- Holidays for the state of Maryland in The United States -->
<holidayCalendar name="Maryland" type="political">
  <include>UnitedStates/Federal.xml</include>

  <holiday type="public" workDayOff="true" schoolDayOff="true">
    <name>Day After Thanksgiving</name>
    <datespec>
      <posdate position="fourth" dayOfWeek="thursday" month="11">
        <plus days="1"/>
      </posdate>
    </datespec>
    <description>The day after Thanksgiving</description>
  </holiday>

  <holiday type="public" workDayOff="true" schoolDayOff="true">
    <name>Election Day</name>
    <datespec>
      <posdate position="first" dayOfWeek="tuesday" month="11">
        <yearMod>2</yearMod>  <!-- every even year -->
      </posdate>
    </datespec>
    <description>Election Day</description>
  </holiday>

</holidayCalendar>

Rough Notes from OpenHolidays Design at KDE PIM Sprint Brno 2013

The OpenHolidays Project

A project to implement a common file format, data repository, and reference libraries for national holiday data. A core goal is to develop a cross-platform community to maintain the Holidays data in a manner similar to the Time Zone database or iso-codes project, and for the data to be available to be used everywhere.

Implementation goals include:

  • A JSON file format for rules for calculating holidays and for distributing calculated holidays
  • A web service to query for the rule files or the calculated holidays
  • A JS reference library implementation for use by websites and apps
  • A C library implementation (using ICU for calendars?)
  • A Qt library implementation
  • Akonadi integration
  • A GUI utility for developers and users to create custom holiday files

Q's

  • Best licence for the data? CC-0? Technically is aggregation of facts, individual facts not protected by copyright, but database could be deemed to be copyrighted.
  • Is JSON the best format? Issues with comments and localization?

File Format

Three forms of the file:

  • Unresolved: the raw or master data files containing the generic rules parts of which may be spread across generic resource files
  • Partly resolved: A standalone file containing all the information required to calculate the rules, i.e. all includes have been merged and simplified
  • Fully resolved: The specific occurrences of the holidays in a given time period


First design resolved format, i.e. what the Qt api will deliver

Key attributes like name, calendar, etc can be overridden in sub-clauses, or derived from first parent, i.e the core recurrence rule entity can fully specify all details required, but where these are common to multiple recurrence rules they can be omitted from the recurrence rule and defined at a holiday or resource level, or even imported

 calendar
 - gregorian
 - julian
 - etc
 HolidayOccurrence
 - official name
 - common name
 - observance name
 - occurrence start datetime
 - occurrence end datetime
 - observance start datetime
 - observance end datetime
 - observance type
 - isWholeDay
 - isMultiDay

Translations

The master files will be defined in en_US for convenience of maintenance. The format will support optional in-file translated strings for fully-resolved format, or custom non-resolved format, but the master files will only include translations for the the official names for regional files for the languages used in that region. This is to keep the file from bloating and being hard to maintain, and to keep the official local names properly controlled. The master files will use standard .po files and the KDE translation framework for allother languages. The standard English strings will be extracted and translated into all other languages using gettext, but scripting will be provided to generate Qt tr and json format translation files from these. The extraction script will also extract the official names and pre-populate the po files for those languages. The web service may offer the ability to inline all available languages on request, or to serve the required po or json tr file.

Resource File Hierarchy

Definition of the default master database file hierarchy, designed to minimise duplication. A fully resolved file may contain elements form many of the master files.

Top level directory holds a set of generic holiday rule files named by their primary category. These are common defined date and name rules that are commonly used by many files. For example, Christmas Day, New Years Day, Valentines Day, Easter, etc. These files only hold the default English name. These files can be included into regional files and the rule extended by any local variations, e.g. define if Easter is a public holiday or not.

The regional files are organised by directories by ISO country code, with subdirs for ISO regional codes if there are sufficient regional variations to warrant a separate file. Each country directory may have one or more files for the different primary categories, or a single file if there are only a few holidays and separate files seem over-kill. These files can have official local name translations held in them. It is strongly

 Categories:
 - Official
 - Civil
 - Cultural
 - NameDay
 - Religious
   - Catholic
   - Orthodox
   - Protestant
   - Islamic
   - Jewish Orthodox
   - Jewish Reform
 - etc
 DaysOff:
 - PublicDayOff - Implies all other?
 - GovernmentDayOff
 - SchoolDayOff
 - FinancialDayOff
 Base file hierarchy:
 /civil.json
 /cultural.json
 /financial.json
 /catholic.json
 /protestant.json
 /orthodox.json
 /islamic.json
 /GB/EAW/official.json
 /GB/EAW/catholic.json
 /GB/EAW/cultural.json
 /NZ/civil.json

Include versus Import

Including another file makes the other files holidays rules available to be extended, but for the holidays to be included in the fully-realised file must be explicitly extended.

Importing another file causes all the other files rules to be included in the fully-realised file.

Comments

JSON cannot have inline comments, but we need to document the rules and sources for the rules in the master files. This will be done via a Source object containing any comments and links required. Shipping this info in the partly or fully resolved files would be wasteful, so the resolving process will strip the Source object out.

Excluded

School Holidays - Best done with iCal? Are they predictable enough? Maybe only historic and current, no future?

Object Hierarchy

 HolidayResource
 - HolidayEvent
   - HolidayOccurrence

The HolidayResource is a set of holiday calculation rules The HolidayEvent is the holiday calculation rule The HolidayOccurrence is an actual occurrence of a holiday on an actual date

The HolidayResource can return the set of HolidayEvent active between two dates The HolidayResource can return the set of HolidayOccurrence between two dates for all HolidayEvent in the HolidayResource The HolidayEvent can return the set of HolidayOccurrence between two dates for itself The HolidayOccurrence only knows about itself

iCal Incidence

 Event ()
 QDate   dateEnd () const
 virtual KDateTime   dtEnd () const
 bool    hasEndDate () const
 QLatin1String   iconName (const KDateTime &recurrenceId=KDateTime()) const
 bool    isMultiDay (const KDateTime::Spec &spec=KDateTime::Spec()) const
 QLatin1String   mimeType () const
 virtual void    shiftTimes (const KDateTime::Spec &oldSpec, const KDateTime::Spec &newSpec)
 Transparency    transparency () const
 IncidenceType   type () const
 QByteArray  typeStr () const
 Incidence ()
 Alarm::List     alarms () const
 QString     altDescription () const
 Attachment::List    attachments () const
 Attachment::List    attachments (const QString &mime) const
 QStringList     categories () const
 QString     categoriesStr () const
 KDateTime   created () const
 QString     customStatus () const
 QString     description () const
 bool    descriptionIsRich () const
 virtual KDateTime   endDateForStart (const KDateTime &startDt) const
 float   geoLatitude () const
 float   geoLongitude () const
 bool    hasAltDescription () const
 bool    hasEnabledAlarms () const
 bool    hasGeo () const
 bool    hasRecurrenceId () const
 QString     instanceIdentifier () const
 bool    localOnly () const
 QString     location () const
 bool    locationIsRich () const
 Alarm::Ptr  newAlarm ()
 int     priority () const
 void    recreate ()
 Recurrence *    recurrence () const
 KDateTime   recurrenceId () const
 ushort  recurrenceType () const
 virtual void    recurrenceUpdated (Recurrence *recurrence)
 bool    recurs () const
 bool    recursAt (const KDateTime &dt) const
 virtual bool    recursOn (const QDate &date, const KDateTime::Spec &timeSpec) const
 QString     relatedTo (RelType relType=RelTypeParent) const
 void    removeAlarm (const Alarm::Ptr &alarm)
 QStringList     resources () const
 int     revision () const
 QString     richDescription () const
 QString     richLocation () const
 QString     richSummary () const
 QString     schedulingID () const
 Secrecy     secrecy () const
 virtual QList< KDateTime >  startDateTimesForDate (const QDate &date, const KDateTime::Spec &timeSpec=KDateTime::LocalZone) const
 virtual QList< KDateTime >  startDateTimesForDateTime (const KDateTime &datetime) const
 Status  status () const
 QString     summary () const
 bool    summaryIsRich () const
 bool    supportsGroupwareCommunication () const
 bool    thisAndFuture () const
 QString     writeAttachmentToTempFile (const Attachment::Ptr &attachment) const
 IncidenceBase ()
 bool    allDay () const
 QStringList     comments () const
 QStringList     contacts () const
 virtual KDateTime   dtStart () const
 Duration    duration () const
 bool    hasDuration () const

OpenHolidays GSOC Project

A GSOC 2014 project proposal has been submitted in implement a replacement for KHolidays. This new project will be known as OpenHolidays as a primary aim is to set up a cross-platform data resource. This section documents the background reading required for candidates for this project. If you wish to apply for the project, please subscribe to the [email protected] mailing list and send your initial contact email there with a cc to [email protected].

A good introduction to the project is the presentation done at the Berlin Desktop Summit in August 2011. (Note the Calendar System implementations details are out of scope for this project).

Next, read through the contents of this wiki page and follow the various links, in particular look through:

  • The current KHoliday library API
  • The current KHoliday data files (but don't worry too much about understanding the file format)
  • The various proposals for new file formats in XML and JSON
  • Pay particular attention to the new OpenHolidays design notes


One compulsory requirement is to integrate the new QOpenHolidays library into KDE using the Akonadi PIM server in a manner similar to iCalendar files where a base event has a start and end date with recurrence dates able to be queried (KHolidays does not offer such an api).

  • Learn some of the basics for the iCalendar design, in particular the relationship between base events and recurrences
  • Learn some of the basics of the KCalCore library, KDE PIM's implementation of an iCalendar library, that QOpenHolidays should operate in a similar manner to.
  • Learn some of the basics of Akonadi and how KCalCore integrates into it as a resource, which QOpenHolidays should operate in a similar manner to.


A major concern is the localization of the files, so you need some understanding of how the KDE localization system works.

It is recommended to get some familiarity with the KDE code development process by submitting some small bug fixes. In this case you could look in Bugzilla for KHolidays data file updates that need to be done.