Amarok/Development/TODO/Refactoring: Difference between revisions
< Amarok | Development
| (One intermediate revision by the same user not shown) | |||
| Line 7: | Line 7: | ||
== QDir == | == QDir == | ||
* Do not use QDir::toNativeSeparor or QDir::Separator when we don't want to show them to the user: Qt does everything with '/' (even on windows!!) | * Do not use QDir::toNativeSeparor or QDir::Separator when we don't want to show them to the user: Qt does everything with '/' (even on windows!!) | ||
== Self coherence == | |||
* In playlists, url.uidUrl() returns a QUrl, in tracks it returns url.url(). Idem for SqlPodcastChannel, .... | |||
Latest revision as of 16:56, 9 November 2015
QUrls
- Use QUrl and store QUrl instead of always changing them to strings
- Often we see parts of code like below, it makes no sense. Just take the string if the URL is not used!!!
QUrl url = QUrl::fromLocalFile(dataPath( "data/playlists/test.m3u" )); QFile file (url.toLocalFile);
QDir
- Do not use QDir::toNativeSeparor or QDir::Separator when we don't want to show them to the user: Qt does everything with '/' (even on windows!!)
Self coherence
- In playlists, url.uidUrl() returns a QUrl, in tracks it returns url.url(). Idem for SqlPodcastChannel, ....